Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html-query-feature #246

Merged
merged 8 commits into from
Nov 22, 2023
Merged

html-query-feature #246

merged 8 commits into from
Nov 22, 2023

Conversation

bastoscorp
Copy link
Contributor

Pull Request Template

Type of Change

Please check the relevant boxes by putting an "x" in the appropriate box.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Description

add html query feature

Related Issue(s)

Please list any related issues or reference them.

Checklist

Please go through this checklist and make sure all applicable tasks have been done.

  • I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed, excepted benchmark because i have an oudated hardware machine
  • I have updated the README.md as necessary if there are changes.
  • I have tested the changes on my local machine before submitting the PR.

Screenshots

If applicable, please provide screenshots, video or GIF to help demonstrate the changes.

@bastoscorp bastoscorp changed the title Develop html-query-feature Nov 13, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (ffc945f) 81.77% compared to head (0d16767) 81.62%.

Files Patch % Lines
core/scenario/scripting/extraction/html.go 59.09% 6 Missing and 3 partials ⚠️
core/scenario/scripting/extraction/base.go 45.45% 5 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #246      +/-   ##
===========================================
- Coverage    81.77%   81.62%   -0.15%     
===========================================
  Files           37       38       +1     
  Lines         5195     5241      +46     
===========================================
+ Hits          4248     4278      +30     
- Misses         766      778      +12     
- Partials       181      185       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatihbaltaci fatihbaltaci merged commit 30023a2 into getanteon:develop Nov 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastoscorp @fatihbaltaci